Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/kube-downscaler] Add support for SecurityContext #18276

Merged
merged 2 commits into from
Oct 24, 2019
Merged

[incubator/kube-downscaler] Add support for SecurityContext #18276

merged 2 commits into from
Oct 24, 2019

Conversation

Pluies
Copy link
Collaborator

@Pluies Pluies commented Oct 24, 2019

Is this a new chart

No

What this PR does / why we need it:

Add support for SecurityContext in the kube-downscaler.

We have a fairly strict PodSecurityPolicy in place, so this will help us comply and run the downscaler!

Also fixes README as values were missing and/or outdated.

Which issue this PR fixes

n/a

Special notes for your reviewer:

none

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Florent Delannoy added 2 commits October 24, 2019 11:33
[incubator/kube-downscaler] Fix README
4817eec 
Add missing values, fix misleading defaults, and add capitalisation :)

Signed-off-by: Florent Delannoy <florent.delannoy.external@ynap.com>
[incubator/kube-downscaler] Add support for SecurityContext
3778f1e 
Also bump the chart's minor version as it's a new feature.

Signed-off-by: Florent Delannoy <florent.delannoy.external@ynap.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Pluies. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 24, 2019
@Pluies
Copy link
Collaborator Author

Pluies commented Oct 24, 2019

/assign @lachie83

@zanhsieh
Copy link
Collaborator

/ok-to-test

@Pluies
If this PR pass, would you mind to become one of this chart owners ?
#13869

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2019
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, Pluies

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 938086a into helm:master Oct 24, 2019
@Pluies
Copy link
Collaborator Author

Pluies commented Oct 24, 2019

@zanhsieh sure thing, I'm ok becoming one of the chart's owners :)

@zanhsieh
Copy link
Collaborator

@zanhsieh sure thing, I'm ok becoming one of the chart's owners :)

@Pluies
Open another PR for OWNERS file modification, add yourself as one of the chart owners, bump the chart version, and let's go from there. 👍

@Pluies Pluies mentioned this pull request Oct 31, 2019
Merged
3 tasks
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@Pluies
[incubator/kube-downscaler] Add support for SecurityContext (helm#18276)
aa72ce0 
* [incubator/kube-downscaler] Fix README

Add missing values, fix misleading defaults, and add capitalisation :)

Signed-off-by: Florent Delannoy <florent.delannoy.external@ynap.com>

* [incubator/kube-downscaler] Add support for SecurityContext

Also bump the chart's minor version as it's a new feature.

Signed-off-by: Florent Delannoy <florent.delannoy.external@ynap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jlegrone jlegrone Awaiting requested review from jlegrone

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@lachie83 lachie83

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pluies @k8s-ci-robot @zanhsieh @davidkarlsen @lachie83 @helm-bot